Show bots with markers rather than inactive (rebase/refactor 1187) #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the STATE_ICON lookup to be typed more cleanly.
This significantly reduces code duplication. Note added in ui_mappings that the order is relevant in the UI.
Bots do not have a dynamic status, so give them a static one.
These are constructed dynamically based on the user status, so if a user may have a "bot" status, a "user_bot" style is now necessary.
This will be picked up using earlier commits, to show it differently in the UI. With a different status, bots are now explicitly placed at the end of the user list. Tests updated. Original logic by Progyan, simplified using logic suggested in review by neiljp in zulip#1187. Co-authored-by: neiljp (Neil Pilgrim) <[email protected]>
neiljp
added
the
PR ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Following a refactor commit that I created incidentally when looking at #1376, I realized that #1187 would be simpler to rebase/refactor/merge, and this is the result. This also introduces a Literal type for the valid status values we use internally.
As per the intent of #1187, this uses a dedicated marker for bots in the user list and wherever else their status appears, such as next to their name in any messages from them (direct messages, stream messages).
Note the marker is not per the initial screenshot of #1187, since we need a simple character that is visible across more fonts/terminals (pending #938), as discussed in #1187 and in the stream.
Outstanding aspect(s)
External discussion & connections
Bot presence markers #T1187How did you test this?
Self-review checklist for each commit
Visual changes
See #1187 and the linked topic.